GrantView Attributes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Grant Synapse Project and Grant Synapse Team
2 tasks
- Add 'Grant Synapse Team', 'Grant Synapse Project' to 'Grant View'/'DependsOn' column - Make 'Grant Synapse Team', 'Grant Synapse Project' not required, since projects and teams will be established after grant info is initially recorded
|
@aditigopalan Everything looks great! I made two very small changes: added the two new attributes to the list of features included in the GrantView manifest and made them non-required, since we will most likely ingress grant info prior to creating the Synapse project and team. As long as you agree with those changes, I think this PR is ready to merge now! |
|
Thanks @Bankso! Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Grant Synapse Project and Grant Synapse Team