Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add timeouts to celery tasks #316

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

SilviaAmAm
Copy link
Contributor

Done in the context of issue maykinmedia/charts#148

Changes

  • Adds a default soft and hard timeout to all celery tasks, to prevent cases where tasks hang and block a worker.

@SilviaAmAm SilviaAmAm marked this pull request as draft January 10, 2025 13:17
@SilviaAmAm SilviaAmAm force-pushed the feature/add-celery-timeout branch 2 times, most recently from 8660f59 to f890e25 Compare January 10, 2025 13:46
@SilviaAmAm SilviaAmAm force-pushed the feature/add-celery-timeout branch 2 times, most recently from 6f17b3b to 54aa761 Compare January 10, 2025 13:50
@SilviaAmAm SilviaAmAm marked this pull request as ready for review January 10, 2025 13:53
@SilviaAmAm SilviaAmAm requested a review from SonnyBA January 10, 2025 13:53
SilviaAmAm added a commit to maykinmedia/charts that referenced this pull request Jan 10, 2025
SilviaAmAm added a commit to maykinmedia/charts that referenced this pull request Jan 10, 2025
SilviaAmAm added a commit to maykinmedia/charts that referenced this pull request Jan 10, 2025
Copy link
Contributor

@SonnyBA SonnyBA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Celery documentation seems to be excluded in this project when building documentation, looks good 👍

@SilviaAmAm SilviaAmAm merged commit 1308427 into master Jan 10, 2025
21 checks passed
@SilviaAmAm SilviaAmAm deleted the feature/add-celery-timeout branch January 10, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants