Feature/310 validation nummeraanduidingid #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 21, 2025
stevenbal
requested changes
Jan 23, 2025
| @@ -0,0 +1,99 @@ | |||
| # Generated by Django 4.2.15 on 2025-01-09 09:22 | |||
There was a problem hiding this comment.
Could you add a test for this migration?
Something like
|
|
||
| organisatie_queryset = Organisatie.objects.annotate( | ||
| length=Length("adres_nummeraanduiding_id") | ||
| ).filter(length__gt=16) |
There was a problem hiding this comment.
I think we should also include the entries that have length less than 16, because those wouldn't pass validation either
| @@ -0,0 +1,133 @@ | |||
| # Generated by Django 4.2.15 on 2025-01-09 09:22 | |||
There was a problem hiding this comment.
Could you also add a test for this migration?
| betrokkene_queryset = Betrokkene.objects.annotate( | ||
| length1=Length("bezoekadres_nummeraanduiding_id"), | ||
| length2=Length("correspondentieadres_nummeraanduiding_id"), | ||
| ).filter(models.Q(length1__gt=16) | models.Q(length2__gt=16)) |
There was a problem hiding this comment.
Same comment as in the other migration, this should include entries with <16 chars too I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
bag_id-> (length=16 and only digits)