Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setup_configuration command #99

Merged
merged 11 commits into from
Apr 23, 2024
Merged

add setup_configuration command #99

merged 11 commits into from
Apr 23, 2024

Conversation

annashamray
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 97.11191% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 95.25%. Comparing base (9be2d29) to head (95d348f).
Report is 4 commits behind head on master.

Files Patch % Lines
src/objecttypes/config/demo.py 88.88% 3 Missing ⚠️
src/objecttypes/config/objects.py 88.88% 3 Missing ⚠️
src/objecttypes/utils/__init__.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   94.98%   95.25%   +0.27%     
==========================================
  Files          88       95       +7     
  Lines        1894     2171     +277     
==========================================
+ Hits         1799     2068     +269     
- Misses         95      103       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annashamray annashamray marked this pull request as ready for review March 5, 2024 16:14
@annashamray annashamray force-pushed the feature/setup-config branch from f8eacc3 to 7e26e1a Compare March 8, 2024 15:34
@annashamray annashamray requested a review from stevenbal April 2, 2024 08:37
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just minor remarks

src/objecttypes/config/demo.py Outdated Show resolved Hide resolved
).exists()

def configure(self):
token_auth, created = TokenAuth.objects.get_or_create(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark with regards to update_or_create

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@annashamray annashamray force-pushed the feature/setup-config branch from 95d348f to 0257da3 Compare April 22, 2024 14:54
@annashamray annashamray requested a review from stevenbal April 22, 2024 15:01
@annashamray annashamray merged commit 3789ec2 into master Apr 23, 2024
8 checks passed
@annashamray annashamray deleted the feature/setup-config branch April 23, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants