-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#513] Release 3.0.0 #149
base: master
Are you sure you want to change the base?
[#513] Release 3.0.0 #149
Conversation
@@ -1,6 +1,6 @@ | |||
from vng_api_common.conf.api import * # noqa - imports white-listed | |||
|
|||
API_VERSION = "2.2.2" | |||
API_VERSION = "3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This applies here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to increase this to v3+ right now, since we still use the v2 endpoint. This would increase to 3.0.0+ if we actually make breaking changes to the API itself.
I don't think we've been updating this version the right way though, I guess technically it should be increased dependent on whether or not there have been major/minor/patch changes to the API. Since this release doesn't change the v2 API, I think we should leave this number unchanged.
(`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/3.0.0..master>`_) | ||
3.0.0 2025-01-10 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/3.0.0/src/objecttypes/api/v2/openapi.yaml>`_, | ||
`Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/3.0.0/src/objecttypes/api/v2/openapi.yaml>`_ | ||
(`diff <https://github.com/maykinmedia/objecttypes-api/compare/2.3.0..3.0.0>`_) | ||
2.3.0 2025-01-10 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.3.0/src/objecttypes/api/v2/openapi.yaml>`_, | ||
`Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.3.0/src/objecttypes/api/v2/openapi.yaml>`_ | ||
(`diff <https://github.com/maykinmedia/objecttypes-api/compare/2.2.2..2.3.0>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/3.0.0..master>`_) | |
3.0.0 2025-01-10 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/3.0.0/src/objecttypes/api/v2/openapi.yaml>`_, | |
`Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/3.0.0/src/objecttypes/api/v2/openapi.yaml>`_ | |
(`diff <https://github.com/maykinmedia/objecttypes-api/compare/2.3.0..3.0.0>`_) | |
2.3.0 2025-01-10 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.3.0/src/objecttypes/api/v2/openapi.yaml>`_, | |
`Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.3.0/src/objecttypes/api/v2/openapi.yaml>`_ | |
(`diff <https://github.com/maykinmedia/objecttypes-api/compare/2.2.2..2.3.0>`_) | |
(`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/3.0.0..master>`_) | |
3.0.0 2025-01-10 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/3.0.0/src/objecttypes/api/v2/openapi.yaml>`_, | |
`Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/3.0.0/src/objecttypes/api/v2/openapi.yaml>`_ | |
(`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/2.3.0..3.0.0>`_) | |
2.3.0 2025-01-10 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.3.0/src/objecttypes/api/v2/openapi.yaml>`_, | |
`Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.3.0/src/objecttypes/api/v2/openapi.yaml>`_ | |
(`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/2.2.2..2.3.0>`_) |
@@ -111,6 +111,25 @@ paths: | |||
/objecttypes/{objecttype_uuid}/versions: | |||
get: | |||
operationId: objectversion_list | |||
description: |- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these descriptions were added intentionally, could you either remove them or add a more correct description of ObjectVersion
?
@@ -1,6 +1,6 @@ | |||
from vng_api_common.conf.api import * # noqa - imports white-listed | |||
|
|||
API_VERSION = "2.2.2" | |||
API_VERSION = "3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to increase this to v3+ right now, since we still use the v2 endpoint. This would increase to 3.0.0+ if we actually make breaking changes to the API itself.
I don't think we've been updating this version the right way though, I guess technically it should be increased dependent on whether or not there have been major/minor/patch changes to the API. Since this release doesn't change the v2 API, I think we should leave this number unchanged.
Partially fixes maykinmedia/objects-api#513
Changes
Adds changes required for releasing 3.0.0. This is the major release part.