bump zgw-consumers to 0.35.1, commonground-api-common to 2.0.1, OAF to 0.9.0 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commonground-api-common to 2.0.1, OAF to 0.9.0
annashamray
force-pushed
the
deps/zgw-consumers
branch
from
f643793 to
ad08c38
Compare
6 tasks
SonnyBA
requested changes
Nov 27, 2024
requirements/base.in
Outdated
| @@ -1,4 +1,5 @@ | |||
| open-api-framework | |||
| git+https://github.com/maykinmedia/commonground-api-common.git@issue/44-migration-error | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
For now I think this can be removed and you can bump it by running bin/compile_dependencies.sh -P commonground-api-common==2.1.0
| @@ -47,7 +47,7 @@ def test_kanaal_create_with_name(self, mock_get_client): | |||
| Test is request to create kanaal is send with specified kanaal name | |||
| """ | |||
| client = mock_get_client.return_value | |||
| client.list.return_value = [] | |||
| client.get.return_value = [] | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I've replaced patch with requests_mock.Mocker for tests, now it should be correct
| @@ -72,27 +72,27 @@ def test_kanaal_create_without_name(self, mock_get_client): | |||
| Test is request to create kanaal is send with default kanaal name | |||
| """ | |||
| client = mock_get_client.return_value | |||
| client.list.return_value = [] | |||
| client.get.return_value = [] | |||
stevenbal
approved these changes
Nov 29, 2024
SonnyBA
approved these changes
Nov 29, 2024
| """ | ||
| Test is request to create kanaal is send with default kanaal name | ||
| """ | ||
| client = mock_get_client.return_value | ||
| client.list.return_value = [] | ||
| m.get(f"{NOTIFICATIONS_API_ROOT}kanaal", json=[]) |
There was a problem hiding this comment.
Nice 👍 , not having to know the exact patch location anymore this way.
SonnyBA
pushed a commit
that referenced
this pull request
Jan 8, 2025
bump zgw-consumers to 0.35.1, commonground-api-common to 2.0.1, OAF to 0.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes maykinmedia/open-api-framework#66
depends on maykinmedia/commonground-api-common#45