Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13] Add prettyfier based on content-type #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[#13] Add prettyfier based on content-type #17

wants to merge 4 commits into from

Conversation

vaszig
Copy link
Collaborator

@vaszig vaszig commented Jul 28, 2023 •
edited by danielmursa-dev
Loading

Fixes #13

Added Prettify button in the admin change view, to get a better view of the output only if it is 'XMLorJSON`.

image

es: XML
image

es: JSON
image

@vaszig vaszig marked this pull request as draft July 28, 2023 15:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.94%. Comparing base (1d1b877) to head (d868a15).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
log_outgoing_requests/admin.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   97.75%   95.94%   -1.81%     
==========================================
  Files          21       22       +1     
  Lines         445      469      +24     
  Branches       57       30      -27     
==========================================
+ Hits          435      450      +15     
- Misses          6       14       +8     
- Partials        4        5       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielmursa-dev danielmursa-dev force-pushed the feature/13-add-body-prettyfier-for-json-and-xml branch from d868a15 to fa22509 Compare December 12, 2024 14:53
@vaszig @danielmursa-dev
[#13] Add prettyfier based on content-type
aca1430 
[#13] Fix admin.js

[#13] Fixed admin button

[#13] Remove unnecessary views and urls

[#13] Remove message in quickstart.rst

[#13] Black
@danielmursa-dev danielmursa-dev force-pushed the feature/13-add-body-prettyfier-for-json-and-xml branch from 39b3d56 to aca1430 Compare December 12, 2024 14:55
@danielmursa-dev
Copy link
Contributor

I changed @vaszig initial idea a bit, to create a views and also the urls to prettify body_response in another view, because I thought it would be better to stay on the same view and only with JS to show or hide prettify_body_response

@danielmursa-dev danielmursa-dev marked this pull request as ready for review December 12, 2024 15:11
@alextreme
Copy link
Member

Nice, thanks Daniel! Will let Steven review

@alextreme alextreme removed their request for review December 12, 2024 15:38
stevenbal
stevenbal requested changes Jan 2, 2025
View reviewed changes
log_outgoing_requests/static/log_outgoing_requests/js/admin.js Outdated Show resolved Hide resolved
log_outgoing_requests/admin.py Show resolved Hide resolved
log_outgoing_requests/admin.py Outdated Show resolved Hide resolved
log_outgoing_requests/static/log_outgoing_requests/js/admin.js
}
} else if (contentType.includes('xml')) {
try {
outputValue = prettifyXml(responseBody);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work for me locally (e.g. if I make a request to https://www.w3schools.com/xml/note.xml)

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmm, weird, I don't know, I tried too and it works.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmursa-dev danielmursa-dev danielmursa-dev left review comments

@stevenbal stevenbal Awaiting requested review from stevenbal

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prettyfier based on content-type
5 participants
@vaszig @codecov-commenter @danielmursa-dev @alextreme @stevenbal