Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table of contents to some API pages #1200

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add table of contents to some API pages #1200

merged 1 commit into from
Oct 7, 2024

Conversation

kevcenteno
Copy link
Member

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2024

Deploying dev-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 53ba67a
Status: ✅  Deploy successful!
Preview URL: https://a19ba42f.dev-site-4ua.pages.dev
Branch Preview URL: https://kevin-toc.dev-site-4ua.pages.dev

View logs

Copy link
Contributor

@mm-jpoole mm-jpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one little question

Comment on lines 14 to 15
{{ if eq .Type "release-note" }}
{{ end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this empty release-note block? I assume it's just WIP but wanted to confirm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops! Deleted and force pushed.

@kevcenteno kevcenteno merged commit b8e6dd5 into kevin/uat Oct 7, 2024
3 checks passed
@kevcenteno kevcenteno deleted the kevin/toc branch October 7, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants