Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use keyword arguments for model classes #189

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Use keyword arguments for model classes #189

merged 9 commits into from
Jan 28, 2025

Conversation

oschwald
Copy link
Member

  • Join some split strings
  • Whitespace improvements
  • Replace raw attribute with to_dict method
  • Make geoip2.mixins geoip2._internal
  • Require record arguments to be keyword arguments
  • Convert model classes to use keyword arguments
  • Make ip_address property more similar to network

@oschwald oschwald force-pushed the greg/eng-1088-implement-minfraud-python-improvements-in-geoip2 branch from 724e605 to 0e8790c Compare January 23, 2025 15:43
@oschwald
Add empty permission block
dedb92c 
As requested by zizmor
horgh
horgh requested changes Jan 27, 2025
View reviewed changes
tests/models_test.py Outdated Show resolved Hide resolved
geoip2/_internal.py Outdated Show resolved Hide resolved
@horgh horgh merged commit fb453e2 into main Jan 28, 2025
36 checks passed
@horgh horgh deleted the greg/eng-1088-implement-minfraud-python-improvements-in-geoip2 branch January 28, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horgh horgh horgh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oschwald @horgh