Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow locales to be a sequence #188

Conversation

oschwald
Copy link
Member

No description provided.

HISTORY.rst Outdated
@@ -9,6 +9,8 @@ History

* ``metro_code`` on ``geoip2.record.Location`` has been deprecated. The
code values are no longer being maintained.
* The type hinting for the optional `locales` keyword argument now allows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be two `s?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! We need an reStructuredText linter as I am always trying to write Markdown.

@horgh horgh merged commit 14621a6 into main Jan 17, 2025
36 checks passed
@horgh horgh deleted the greg/eng-841-easy-way-to-serialize-python-minfraud-model-objects-to-json branch January 17, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants