Skip to content

Commit

Permalink
Merge branch '8.x' into backport/8.x/pr-117589
Browse files Browse the repository at this point in the history
  • Loading branch information
maxhniebergall authored Dec 16, 2024
2 parents dadb2d4 + 0a599f9 commit c921601
Show file tree
Hide file tree
Showing 98 changed files with 1,689 additions and 1,579 deletions.
4 changes: 3 additions & 1 deletion .buildkite/pipelines/pull-request/part-1.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
steps:
- label: part-1
command: .ci/scripts/run-gradle.sh -Dignore.tests.seed checkPart1
command: |
.buildkite/scripts/spotless.sh # This doesn't have to be part of part-1, it was just a convenient place to put it
.ci/scripts/run-gradle.sh -Dignore.tests.seed checkPart1
timeout_in_minutes: 300
agents:
provider: gcp
Expand Down
4 changes: 3 additions & 1 deletion .buildkite/pipelines/pull-request/precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ config:
skip-labels: []
steps:
- label: precommit
command: .ci/scripts/run-gradle.sh -Dignore.tests.seed precommit
command: |
.buildkite/scripts/spotless.sh
.ci/scripts/run-gradle.sh -Dignore.tests.seed precommit
timeout_in_minutes: 300
agents:
provider: gcp
Expand Down
44 changes: 44 additions & 0 deletions .buildkite/scripts/spotless.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
#!/bin/bash

if [[ -z "${BUILDKITE_PULL_REQUEST:-}" ]]; then
echo "Not a pull request, skipping spotless"
exit 0
fi

if ! git diff --exit-code; then
echo "Changes are present before running spotless, not running"
git status
exit 0
fi

NEW_COMMIT_MESSAGE="[CI] Auto commit changes from spotless"
PREVIOUS_COMMIT_MESSAGE="$(git log -1 --pretty=%B)"

echo "--- Running spotless"
.ci/scripts/run-gradle.sh -Dscan.tag.NESTED spotlessApply

if git diff --exit-code; then
echo "No changes found after running spotless. Don't need to auto commit."
exit 0
fi

if [[ "$NEW_COMMIT_MESSAGE" == "$PREVIOUS_COMMIT_MESSAGE" ]]; then
echo "Changes found after running spotless"
echo "CI already attempted to commit these changes, but the file(s) seem to have changed again."
echo "Please review and fix manually."
exit 1
fi

git config --global user.name elasticsearchmachine
git config --global user.email '[email protected]'

gh pr checkout "${BUILDKITE_PULL_REQUEST}"
git add -u .
git commit -m "$NEW_COMMIT_MESSAGE"
git push

# After the git push, the new commit will trigger a new build within a few seconds and this build should get cancelled
# So, let's just sleep to give the build time to cancel itself without an error
# If it doesn't get cancelled for some reason, then exit with an error, because we don't want this build to be green (we just don't want it to generate an error either)
sleep 300
exit 1
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,12 @@ resources:

# List of project maintainers
maintainers:
- name: "Rory Hunter"
email: "[email protected]"
username: "rory"
- name: "Mark Vieira"
email: "[email protected]"
username: "mark-vieira"
- name: "Rene Gröschke"
email: "[email protected]"
username: "breskeby"
- email: "[email protected]"
name: "Alexander Klepal"
username: "alexander.klepal"
Expand Down
6 changes: 6 additions & 0 deletions docs/changelog/117643.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 117643
summary: Drop null columns in text formats
area: ES|QL
type: bug
issues:
- 116848
5 changes: 5 additions & 0 deletions docs/changelog/117851.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 117851
summary: Addition of `tier_preference`, `creation_date` and `version` fields in Elasticsearch monitoring template
area: Monitoring
type: enhancement
issues: []
5 changes: 5 additions & 0 deletions docs/changelog/118454.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 118454
summary: Fix RLIKE folding with (unsupported) case insensitive pattern
area: ES|QL
type: bug
issues: []
6 changes: 6 additions & 0 deletions docs/changelog/118474.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 118474
summary: Esql bucket function for date nanos
area: ES|QL
type: enhancement
issues:
- 118031
Loading

0 comments on commit c921601

Please sign in to comment.