Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional error handling without exception. #71

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pavel-jurasek
Copy link

This PR fix several things:

  • Fix warning related to last version RSpec
  • Fix duplication for spec_helper require statment
  • Fix problem with using non bang method for raising exceptions (param raise exception)
  • Add ability to handler error within request block

@mattt
Copy link
Owner

mattt commented Mar 20, 2018

Thanks for your patch, @pavel-jurasek-hypofriend-de. Apologies for the delay in reviewing this.

I'm currently triaging the most pressing issues (primarily Sinatra 2.0 compatibility) for the next release, but am definitely interested in incorporating this into the next major version.

In the meantime, I'm happy to report that the rspec issue you identified is now fixed with 1d811d9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants