Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: DM list should scroll to reveal hidden items during navigation with up/down arrow keys #198

Merged

Conversation

Victor-Nyagudi
Copy link
Contributor

Summary

This PR adds the test steps for testing the DM list's scrolling behavior when a user navigates using the Up and Down arrow keys.

Is the feature in stable branch or under review?

Test server

mattermost/mattermost#29565

Test client

  • Browser

@Victor-Nyagudi
Copy link
Contributor Author

I don't see any reviewers automatically assigned so I'm wondering if you might know who I should tag @yasserfaraazkhan?

I see you've added some PRs to this repo.

Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Victor-Nyagudi 🎉

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@saturninoabril
Copy link
Member

/update-branch

@saturninoabril saturninoabril added 3: Reviews Complete All reviewers have approved the pull request and removed Lifecycle/1:stale labels Jan 25, 2025
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Victor-Nyagudi, really appreciate your contributions!

@saturninoabril saturninoabril merged commit f516521 into mattermost:main Jan 25, 2025
1 check failed
@saturninoabril
Copy link
Member

(failed job not related to this PR)

@saturninoabril
Copy link
Member

@Victor-Nyagudi Test case saved as MM-T5669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants