-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version v2.0.0 (closed, renamed to v1.7.0) #321
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 19.33% 19.33%
=======================================
Files 9 9
Lines 1479 1479
=======================================
Hits 286 286
Misses 1138 1138
Partials 55 55 ☔ View full report in Codecov by Sentry. |
Looking at the PR description, I don't think all of those PRs are new to this release. For instance, these two have definitely been released, and many more:
The process of determining what's in the new release is a bit of a manual process when we have the dot release cherry-picking process that we have. It doesn't need to be 100% accurate since this is difficult to verify, but try your best to pick out the work that is specific to this release. Essentially things that have built up on master that we didn't end up ever dot releasing, which I know is difficult because of the many different ways different people may have organized those commits when preparing the dot releases. What is usually built up in the master branch are non-urgent features and low impact defects. Also, why is this specifically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and Approved
Working fine in all the conditions, LGTM.
To be more clear, here are the definitions to use to follow semantic version, or "semver": Given a version number Major - version when you make incompatible API changes Additional labels for pre-release and build metadata are available as extensions to the In our case this typically means:
In this case of this release, it will probably be a minor release, since I think there are new features here, and probably not any intentional breaking changes |
Yeah I agree with you @mickmister the only reason we were thinking of making it a major release was due to removal of the deprecated JWT settings from the plugin #299 Please let me know if we should create the release as |
@mickmister I've updated the description after removing the issues/PRs which were released in previous releases. |
@avas27JTG That deprecation is really more of a deprecation from Zoom, and not so much our software. AFAIK the JWT offering doesn't work at all anymore on Zoom plugin version. Because of that, I don't think we should treat the new release as a breaking change in that regard. I think we should go with |
Sounds good, thanks for clarifying. |
plugin.json
Outdated
@@ -6,7 +6,7 @@ | |||
"support_url": "https://github.com/mattermost/mattermost-plugin-zoom/issues", | |||
"release_notes_url": "https://github.com/mattermost/mattermost-plugin-zoom/releases/tag/v1.5.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI we always have to change this value too
"release_notes_url": "https://github.com/mattermost/mattermost-plugin-zoom/releases/tag/v1.5.1", | |
"release_notes_url": "https://github.com/mattermost/mattermost-plugin-zoom/releases/tag/v1.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, thanks
@mickmister created a new PR #322 as I also changed the branch name to |
Summary
/zoom start
slash command posts in thread #228