Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version v2.0.0 (closed, renamed to v1.7.0) #321

Closed
wants to merge 3 commits into from

Conversation

avas27JTG
Copy link
Contributor

@avas27JTG avas27JTG commented Nov 14, 2023

Summary

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba2d98c) 19.33% compared to head (2d70109) 19.33%.
Report is 1 commits behind head on master.

❗ Current head 2d70109 differs from pull request most recent head 8b95f53. Consider uploading reports for the commit 8b95f53 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   19.33%   19.33%           
=======================================
  Files           9        9           
  Lines        1479     1479           
=======================================
  Hits          286      286           
  Misses       1138     1138           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 14, 2023
@hanzei hanzei added this to the v2.0.0 milestone Nov 14, 2023
@mickmister
Copy link
Contributor

Looking at the PR description, I don't think all of those PRs are new to this release. For instance, these two have definitely been released, and many more:

The process of determining what's in the new release is a bit of a manual process when we have the dot release cherry-picking process that we have. It doesn't need to be 100% accurate since this is difficult to verify, but try your best to pick out the work that is specific to this release. Essentially things that have built up on master that we didn't end up ever dot releasing, which I know is difficult because of the many different ways different people may have organized those commits when preparing the dot releases. What is usually built up in the master branch are non-urgent features and low impact defects.

Also, why is this specifically v2.0.0 and not a minor or dot release?

Copy link
Contributor

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Approved
Working fine in all the conditions, LGTM.

@mickmister
Copy link
Contributor

mickmister commented Nov 15, 2023

To be more clear, here are the definitions to use to follow semantic version, or "semver":

https://semver.org

Given a version number Major.Minor.Patch, increment the:

Major - version when you make incompatible API changes
Minor - version when you add functionality in a backward compatible manner
Patch - version when you make backward compatible bug fixes

Additional labels for pre-release and build metadata are available as extensions to the Major.Minor.Patch format.


In our case this typically means:

  • Major - Breaking changes and (significant) deprecations
  • Minor - New features or significant change in how the program functions to the user. Basically a change in requirements of the program
  • Patch/Dot - Bug fixes

In this case of this release, it will probably be a minor release, since I think there are new features here, and probably not any intentional breaking changes

@avas27JTG
Copy link
Contributor Author

avas27JTG commented Nov 16, 2023

Yeah I agree with you @mickmister the only reason we were thinking of making it a major release was due to removal of the deprecated JWT settings from the plugin #299

Please let me know if we should create the release as 1.7.0 or 2.0.0 considering above change?

@avas27JTG
Copy link
Contributor Author

@mickmister I've updated the description after removing the issues/PRs which were released in previous releases.

@mickmister
Copy link
Contributor

the only reason we were thinking of making it a major release was due to removal of the deprecated JWT settings from the plugin #299

@avas27JTG That deprecation is really more of a deprecation from Zoom, and not so much our software. AFAIK the JWT offering doesn't work at all anymore on Zoom plugin version. Because of that, I don't think we should treat the new release as a breaking change in that regard. I think we should go with 1.7.0 for this release

@avas27JTG
Copy link
Contributor Author

the only reason we were thinking of making it a major release was due to removal of the deprecated JWT settings from the plugin #299

@avas27JTG That deprecation is really more of a deprecation from Zoom, and not so much our software. AFAIK the JWT offering doesn't work at all anymore on Zoom plugin version. Because of that, I don't think we should treat the new release as a breaking change in that regard. I think we should go with 1.7.0 for this release

Sounds good, thanks for clarifying.

@avas27JTG avas27JTG changed the title Bump version v2.0.0. Bump version v1.7.0. Nov 20, 2023
plugin.json Outdated
@@ -6,7 +6,7 @@
"support_url": "https://github.com/mattermost/mattermost-plugin-zoom/issues",
"release_notes_url": "https://github.com/mattermost/mattermost-plugin-zoom/releases/tag/v1.5.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we always have to change this value too

Suggested change
"release_notes_url": "https://github.com/mattermost/mattermost-plugin-zoom/releases/tag/v1.5.1",
"release_notes_url": "https://github.com/mattermost/mattermost-plugin-zoom/releases/tag/v1.7.0",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, thanks

@avas27JTG avas27JTG closed this Nov 20, 2023
@avas27JTG avas27JTG deleted the release-bump-2.0.0 branch November 20, 2023 14:47
@avas27JTG
Copy link
Contributor Author

@mickmister created a new PR #322 as I also changed the branch name to release-bump-1.7.0 in place of ...-2.0.0.

@mickmister mickmister changed the title Bump version v1.7.0. Bump version v2.0.0 (closed) Nov 20, 2023
@mickmister mickmister changed the title Bump version v2.0.0 (closed) Bump version v2.0.0 (closed, renamed to v1.7.0) Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants