Skip to content

Commit

Permalink
Fix failing CI by updating golang-ci lint version (#403)
Browse files Browse the repository at this point in the history
* upgraded golangci-lint version from 1.51.1 to 1.55.0

* updated the mainfest to remove duplicate string usage
  • Loading branch information
Kshitij-Katiyar authored Nov 13, 2024
1 parent 22b9f26 commit 60362f3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ apply:
## Install go tools
install-go-tools:
@echo Installing go tools
$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.1
$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.0
$(GO) install gotest.tools/[email protected]

## Runs eslint and golangci-lint
Expand Down
10 changes: 4 additions & 6 deletions build/manifest/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
"github.com/pkg/errors"
)

const stringFormatter = `%s`

const pluginIDGoFileTemplate = `// This file is automatically generated. Do not modify it manually.
package main
Expand All @@ -23,9 +25,7 @@ import (
var manifest *model.Manifest
const manifestStr = ` + "`" + `
%s
` + "`" + `
const manifestStr = ` + "`" + stringFormatter + "`" + `
func init() {
_ = json.NewDecoder(strings.NewReader(manifestStr)).Decode(&manifest)
Expand All @@ -34,9 +34,7 @@ func init() {

const pluginIDJSFileTemplate = `// This file is automatically generated. Do not modify it manually.
const manifest = JSON.parse(` + "`" + `
%s
` + "`" + `);
const manifest = JSON.parse(` + "`" + stringFormatter + "`" + `);
export default manifest;
`
Expand Down

0 comments on commit 60362f3

Please sign in to comment.