[MM-956]: Added server testcase for webhook.go #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2024
wiggin77
approved these changes
Dec 10, 2024
raghavaggarwal2308
requested changes
Dec 10, 2024
| ) | ||
|
|
||
| func TestPostPushEvent(t *testing.T) { | ||
| mockKvStore, mockAPI, _, _, _ := GetTestSetup(t) |
There was a problem hiding this comment.
move inside, as it can cause some issues later
| ) | ||
|
|
||
| func TestPostPushEvent(t *testing.T) { | ||
| mockKvStore, mockAPI, _, _, _ := GetTestSetup(t) |
There was a problem hiding this comment.
Suggested change
| mockKvStore, mockAPI, _, _, _ := GetTestSetup(t) | |
| mockKVStore, mockAPI, _, _, _ := GetTestSetup(t) |
| pushEvent: GetMockPushEvent(), | ||
| setup: func() { | ||
| mockKvStore.EXPECT().Get(SubscriptionsKey, gomock.Any()).DoAndReturn(func(key string, value interface{}) error { | ||
| if v, ok := value.(**Subscriptions); ok { |
There was a problem hiding this comment.
Why are we using double * here?
| name: "Error creating post", | ||
| pushEvent: GetMockPushEvent(), | ||
| setup: func() { | ||
| mockKvStore.EXPECT().Get(SubscriptionsKey, gomock.Any()).DoAndReturn(func(key string, value interface{}) error { |
There was a problem hiding this comment.
Create separate functions for the nested one. Its getting very complicated here
| setup func() | ||
| }{ | ||
| { | ||
| name: "no subscription found", |
There was a problem hiding this comment.
Suggested change
| name: "no subscription found", | |
| name: "No subscription found", |
For consistency, check everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added server testcase for webhook.go