[MM-62066] Render fallback config settings when plugin is disabled #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
cpoile
approved these changes
Dec 11, 2024
DHaussermann
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Tested and passed.
Tested as part of the server change that displays fall back config.
mattermost/mattermost#29500 (review)
No issues found.
LGTM!
DHaussermann
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's the matching PR for mattermost/mattermost#29500
Ticket Link
https://mattermost.atlassian.net/browse/MM-62066