Cherry-pick of #849: Use os.MkdirAll, which is thread-safe #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same race condition does happen in the implementation of os.MkdirAll[0], but that code there takes it into account and re-checks the second error (the one on Mkdir), and it ends up returning nil if the directory is indeed created, thus avoiding the race condition and making os.MkdirAll thread-safe. [0] https://github.com/golang/go/blob/e33f7c42b084182a3a88ef79857e33c11627159a/src/os/path.go#L19-L66
cpoile
approved these changes
Nov 20, 2024
agarciamontoro
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick #849 to
release-1.23. Even though I have not released the RC-1 version yet, the branch is protected and I cannot force-push to it (I should have cut it after #849 was merged, but alas). Anyway, we need to cherry-pick that now.Ticket Link
--