Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Add test role #1618

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Chore: Add test role #1618

merged 3 commits into from
Oct 2, 2024

Conversation

catalintomai
Copy link
Contributor

@catalintomai catalintomai commented Oct 1, 2024 •
edited
Loading

Summary

Add test role to help validate various connection strings.

@catalintomai catalintomai added the 2: Dev Review Requires review by a core committer label Oct 1, 2024
ifoukarakis
ifoukarakis approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@ifoukarakis ifoukarakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Shall we merge it or wait for adding the user in the same PR?

@catalintomai
Copy link
Contributor Author

catalintomai commented Oct 2, 2024 •
edited
Loading

Looks OK. Shall we merge it or wait for adding the user in the same PR?

@ifoukarakis , Daniel add the TEST_USER. Updated the PR to reference it.

@ifoukarakis ifoukarakis merged commit 4d5d5f2 into master Oct 2, 2024
3 checks passed
@ifoukarakis ifoukarakis deleted the chore_add_test_user branch October 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifoukarakis ifoukarakis ifoukarakis approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catalintomai @ifoukarakis