Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy to bump postgres minimum version #7709

Merged
merged 19 commits into from
Jan 27, 2025
Merged

Add policy to bump postgres minimum version #7709

merged 19 commits into from
Jan 27, 2025

Conversation

agnivade
Copy link
Member

No description provided.

@agnivade agnivade added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Jan 21, 2025
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 99a4ed3

@cwarnermm
Copy link
Member

@agnivade - I've committed updates to convert the Markdown draft to ReStructuredText, wordsmithed the content for simplicity, and added links to these policy details to related pages. Please review the wordsmithing to ensure that the updated copy aligns with your intentions.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA e10b928

@streamer45 streamer45 requested a review from sadohert January 21, 2025 18:07
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left a non-blocking suggestion.

source/install/prepare-mattermost-database.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@sadohert sadohert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just made one comment, and +1 from me on the table that spells out the forecasted support plan.

source/install/prepare-mattermost-database.rst Outdated Show resolved Hide resolved
source/install/prepare-mattermost-database.rst Outdated Show resolved Hide resolved
source/install/prepare-mattermost-database.rst Outdated Show resolved Hide resolved
source/install/prepare-mattermost-database.rst Outdated Show resolved Hide resolved

Mattermost v10.6 is not an :ref:`Extended Support Release (ESR) <about/release-policy:extended support releases>`. Going forward, this database version support policy will only apply to ESR releases. When a Postgres version reaches its end of life (EOL), Mattermost will require a newer version starting with the next scheduled ESR release.

Customers will have 9 months to plan, test, and upgrade their Postgres version before the new requirement takes effect. If you need more time, extended ESR support may be available on a case-by-case basis. This policy aims to provide clarity and transparency so you can align database upgrades with the Mattermost release schedule. Contact a `Mattermost Expert <https://mattermost.com/contact-sales/>`_. to discuss your options.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Customers will have 9 months to plan, test, and upgrade their Postgres version before the new requirement takes effect. If you need more time, extended ESR support may be available on a case-by-case basis. This policy aims to provide clarity and transparency so you can align database upgrades with the Mattermost release schedule. Contact a `Mattermost Expert <https://mattermost.com/contact-sales/>`_. to discuss your options.
Customers will have 9 months to plan, test, and upgrade their PostgreSQL version before the new requirement takes effect. If you need more time, extended ESR support may be available on a case-by-case basis. This policy aims to provide clarity and transparency so you can align database upgrades with the Mattermost release schedule. Contact a `Mattermost Expert <https://mattermost.com/contact-sales/>`_. to discuss your options.

source/install/software-hardware-requirements.rst Outdated Show resolved Hide resolved
Copy link

Newest code from mattermost has been published to preview environment for Git SHA c449e5f

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 27232c0

Copy link

Newest code from mattermost has been published to preview environment for Git SHA c8dafd5

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 5a36c06

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 70eae77

.. note::

- Mattermost v10.6 is not an :ref:`Extended Support Release (ESR) <about/release-policy:extended support releases>`. Going forward, this database version support policy will only apply to ESR releases.
- When a PostgreSQL version reaches its end of life (EOL), Mattermost will require a newer version starting with the next scheduled ESR release. This means the following future PostgreSQL minimum version increases as follows:
Copy link
Member

@cwarnermm cwarnermm Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@streamer45 & @sadohert - Is this what you had in mind? I'm not 100% sure I have the ESR dates/versions correct, given that March 2025 will be the v10.5 ESR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works. Combining these 2 resources:

https://www.postgresql.org/support/versioning/

https://docs.mattermost.com/about/mattermost-server-releases.html

I was imagining a table like:

Mattermost ESR Release Date Minimum Postgres Version
9.11 Aug 16,2025 12.x
10.5 Feb 16,2025 13.x
10.11 Aug 16, 2025 13.x
11.5 * Feb 16, 2026 14.x

* Forecasted version and date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadohert - One concern for the table is that it can lead to further maintenance effort for the team. Because now it's one more item to keep track of and update every ESR. I was thinking that just the 2 lines would be sufficient for customers to get an idea and extrapolate. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agnivade - I share the same concerns about maintenance. @sadohert - Are you open to publishing what we have drafted and iterate if we start receiving feedback asking for further clarity?

Copy link
Contributor

@streamer45 streamer45 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the maintenance effort required to update a single row in the table is justified in this case as it adds valuable clarity for customers and eliminates any potential ambiguity. We could consider incorporating this as part of a playbook's checklist for the ESR release process.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadohert - I agree with a release playbook maintenance step to ensure this guidance remains accurate. @amyblais - How do you recommend we approach this, given that it isn't something we need to review on a monthly basis?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing the minimum PG version for 11.5 as Postgres 14.

Postgres 13 goes EOL on Nov. 13th/2025, according to https://endoflife.date/postgresql

So this coming November PG 13 goes EOL... I thought our policy was that the next ESR will bump... and thus our minimum goes to 14?

@agnivade ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my brain stopped functioning there. You are right @sadohert.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add this step to the release playbook.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @amyblais!

@sadohert - I believe this PR is ready for your final review.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 20c3ca1

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 1da5289

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 5872acf

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 8559416

@cwarnermm cwarnermm requested a review from sadohert January 24, 2025 13:28
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 6b185a9

Copy link

Newest code from mattermost has been published to preview environment for Git SHA ce70c53

@sadohert
Copy link
Contributor

Looks good to me. If we have the "Process" step documented to maintain/update this section of the docs when we publish a new ESR, I think its good to ship.

@amyblais do you have that capture in a Playbook or checklist somewhere?

+-----------------------------------------------------------+------------------+--------------------------------+
| v10.11 ESR | 2025-8-15 | 13.x |
+-----------------------------------------------------------+------------------+--------------------------------+
| v11.5 ESR ``*`` | 2026-2-15 | 14.x (EOL 2025-11-13) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PSQL v14 goes EOL November 12, 2026

@amyblais
Copy link
Member

@amyblais do you have that capture in a Playbook or checklist somewhere?

Yes, this is captured in a release playbook.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 856079a

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 26e2fa7

Copy link
Contributor

@sadohert sadohert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @cwarnermm !

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Jan 27, 2025
@cwarnermm cwarnermm merged commit f50b5fc into master Jan 27, 2025
4 checks passed
@cwarnermm cwarnermm deleted the bumpPostgres branch January 27, 2025 16:47
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 6d40e5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants