Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testing note #7680

Open
wants to merge 1 commit into
base: v10.4-documentation
Choose a base branch
from
Open

Conversation

cwarnermm
Copy link
Member

@cwarnermm cwarnermm commented Jan 7, 2025

Docs to-do: Add updated note to specific user count levels as needed

@cwarnermm cwarnermm added the 1: Dev Review Requires review by a core commiter label Jan 7, 2025
@cwarnermm cwarnermm added this to the v10.4.0 milestone Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Newest code from mattermost has been published to preview environment for Git SHA e38d5fc

Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great from a technical point of view. But I'd love to get the PM point of view as well before merging, if that's possible. cc/@wiersgallak

@agarciamontoro agarciamontoro added the 1: PM Review Requires review by a product manager label Jan 7, 2025
@cwarnermm cwarnermm requested a review from sadohert January 10, 2025 14:23
@sadohert
Copy link
Contributor

Hey All... just reviewed the note. Good we caught that.

I think we need to add something else here.

When I read this:

the Elasticsearch cluster is underspecified for user counts of 30k users or more

I immediately wonder "Okay, so what should it be for those customers?" The "overspecified" case doesn't concern me really. Its the Elasticsearch underspecified.

In the absence of bandwidth to gather data-driven values for these variables, can we adapt the specifications recommended for ES >=30k to something we would consider "borderline OVERspecified", then our "Important Note" would read more like:

Hey, these were not analyzed deeply in the scope of testing for this round. Its possible lower instance specs will be sufficient. We recommend monitoring the performance of the Elasticsearch cluster to identify opportunities for reduced specifications.

@cwarnermm cwarnermm removed the request for review from wiersgallak January 10, 2025 15:09
@cwarnermm cwarnermm removed the 1: PM Review Requires review by a product manager label Jan 10, 2025
@cwarnermm
Copy link
Member Author

@agarciamontoro - Can I get your help incorporating @sadohert's input into the note details, please? I'll ensure the note displays on applicable pages in the scale section.

@agarciamontoro agarciamontoro self-requested a review January 10, 2025 16:13
@agarciamontoro
Copy link
Member

I'm onboard with Stu's idea, but coming up with such a specification without testing is... scary. Let's discuss this next week, I self-requested a review so I don't forget :)

@cwarnermm cwarnermm modified the milestone: v10.4.0 Jan 10, 2025
@cwarnermm cwarnermm mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Dev Review Requires review by a core commiter 2. SME Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants