-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added testing note #7680
base: v10.4-documentation
Are you sure you want to change the base?
Added testing note #7680
Conversation
Newest code from mattermost has been published to preview environment for Git SHA e38d5fc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great from a technical point of view. But I'd love to get the PM point of view as well before merging, if that's possible. cc/@wiersgallak
Hey All... just reviewed the note. Good we caught that. I think we need to add something else here. When I read this:
I immediately wonder "Okay, so what should it be for those customers?" The "overspecified" case doesn't concern me really. Its the Elasticsearch underspecified. In the absence of bandwidth to gather data-driven values for these variables, can we adapt the specifications recommended for ES >=30k to something we would consider "borderline OVERspecified", then our "Important Note" would read more like:
|
@agarciamontoro - Can I get your help incorporating @sadohert's input into the note details, please? I'll ensure the note displays on applicable pages in the scale section. |
I'm onboard with Stu's idea, but coming up with such a specification without testing is... scary. Let's discuss this next week, I self-requested a review so I don't forget :) |
Docs to-do: Add updated note to specific user count levels as needed