Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin.go #66

Closed
wants to merge 2 commits into from
Closed

Conversation

theme1256
Copy link

Summary

Possible fix for issue #41.
Changing from markdown image to image-attatchment.
I've never written Go before and havn't tried the edit (because I don't have the tools), but VSCode can't find any syntax errors.

Ticket Link

Issue 41

Possible fix for issue mattermost-community#41.
Changing from markdown image to image-attatchment
@theme1256 theme1256 requested a review from hanzei as a code owner February 22, 2023 21:03
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please share a before and after screenshot?

@theme1256
Copy link
Author

Here's a screenshot showing one message before change (the blank one) and another efter change (the working one)
Screenshot_20230222-225339

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to merge the PR as I don't full understand why the workaround is needed. Other plugin like https://github.com/moussetc/mattermost-plugin-giphy do use image and work on mobile.

@theme1256
Copy link
Author

Sure, giphy works fine, but this plugin doesn't, despite both of them sending an image in markdown.

I did a bit of testing, manually sending images and gifs, and it turns out that gifs work just fine, but images don't.

So this PR is needed, because regular images don't work in the app when sendt in markdown, but fine when sendt as attatchments.

@theme1256
Copy link
Author

Never mind.
It actually doesn't work.

I tried building and uploading the plugin to my own server. This code works, but the image still doesn't show. I guess this will have to be fixed in the actual app and not in this plugin.

@theme1256 theme1256 closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants