Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-219] Fix issue of username not visible in jitsi embed meeting #240

Merged
merged 9 commits into from
Jun 19, 2024
Merged

[MM-219] Fix issue of username not visible in jitsi embed meeting #240

merged 9 commits into from
Jun 19, 2024

Conversation

ayusht2810
Copy link
Contributor

Summary

  • Fixed issue of username not visible in jitsi embed meeting
  • Updated the display name in jitsi window meeting from full name to username
  • Fixed and updated test cases

Ticket Link

NA

Screenshot

image

What to test?

  • Check if the username is present in the jitsi meeting window.

@ayusht2810 ayusht2810 requested a review from larkox as a code owner February 15, 2024 11:32
@ayusht2810 ayusht2810 self-assigned this Feb 15, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Feb 15, 2024
larkox
larkox reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions from my side.

webapp/src/components/post_type_jitsi/post_type_jitsi.tsx Outdated Show resolved Hide resolved
webapp/src/components/conference/conference.tsx Show resolved Hide resolved
@Kshitij-Katiyar
Copy link
Contributor

@mickmister Gentle reminder to review the PR

@mickmister mickmister added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels May 24, 2024
AayushChaudhary0001
AayushChaudhary0001 approved these changes May 28, 2024
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR above has been tested for the following conditions:-

  • Displays username instead of full name in meeting

The PR was working fine for the above condition, LGTM. Approved.
cc: @Kshitij-Katiyar @mickmister

@mickmister mickmister merged commit ced05f5 into master Jun 19, 2024
3 checks passed
@mickmister mickmister deleted the MM-219 branch June 19, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshitij-Katiyar Kshitij-Katiyar Kshitij-Katiyar left review comments

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@mickmister mickmister mickmister approved these changes

@larkox larkox larkox approved these changes

@raghavaggarwal2308 raghavaggarwal2308 Awaiting requested review from raghavaggarwal2308

Assignees

@ayusht2810 ayusht2810

Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ayusht2810 @Kshitij-Katiyar @larkox @mickmister @raghavaggarwal2308 @AayushChaudhary0001 @hanzei