-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-59253]: Remove plugin code from focalboard repo #5027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianunez
reviewed
Jul 25, 2024
harshilsharma63
approved these changes
Jul 25, 2024
Rajat-Dabade
added
2: Dev Review
Requires review by a core committer
Do Not Merge
Should not be merged until this label is removed
labels
Jul 29, 2024
marianunez
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rajat-Dabade ! Some minor comments below
* refactor: removed mattermost-plugin folder * reverted the mysql image version * Removed `mattermost-plugin` from make rules (#5030) * removed mattermost-plugin from make rules * removed: mattermost-plugin code from the repo * updated snapshot and fix test (#5031) * updated snapshot and fix test * Updated snapshot and removed unnecessary tests * chore: minor fix ci * refactor: updated the mac-os version supported by github actions * reverted: mac os version * refactor: updated mac os version and also changed docker-compose to docker compose * removed version from docker compose as no long needed * reverted mysql docker version * updated mysql version * testing * revert testing * refactor: added version for mysql docker compose file * test: test commit * updated snapshot and fix test (#5032) * removed mattermost-plugin from make rules * removed: mattermost-plugin code from the repo * updated snapshot and fix test * Updated snapshot and removed unnecessary tests * chore: minor fix ci * refactor: removed isplugin code from server * final attempt * ci: Minor ci tweaks and upgrades --------- Co-authored-by: Antonis Stamatiou <[email protected]>
Rajat-Dabade
removed
the
Do Not Merge
Should not be merged until this label is removed
label
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include: