Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-59253]: Remove plugin code from focalboard repo #5027

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

Rajat-Dabade
Copy link
Contributor

This PR include:

  • Removing isPlugin check from webapp.

@Rajat-Dabade Rajat-Dabade self-assigned this Jul 23, 2024
@marianunez marianunez requested a review from jespino July 23, 2024 13:48
docker-testing/docker-compose-mysql.yml Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
webapp/src/components/sidebar/sidebar.tsx Show resolved Hide resolved
webapp/src/components/withWebSockets.tsx Outdated Show resolved Hide resolved
@Rajat-Dabade Rajat-Dabade added 2: Dev Review Requires review by a core committer Do Not Merge Should not be merged until this label is removed labels Jul 29, 2024
Copy link
Contributor

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rajat-Dabade ! Some minor comments below

.vscode/settings.json Show resolved Hide resolved
webapp/src/components/cardDialog.tsx Outdated Show resolved Hide resolved
Rajat-Dabade and others added 3 commits August 20, 2024 19:17
* refactor: removed mattermost-plugin folder

* reverted the mysql image version

* Removed `mattermost-plugin` from make rules (#5030)

* removed mattermost-plugin from make rules

* removed: mattermost-plugin code from the repo

* updated snapshot and fix test (#5031)

* updated snapshot and fix test

* Updated snapshot and removed unnecessary tests

* chore: minor fix ci

* refactor: updated the mac-os version supported by github actions

* reverted: mac os version

* refactor: updated mac os version and also changed docker-compose to docker compose

* removed version from docker compose as no long needed

* reverted mysql docker version

* updated mysql version

* testing

* revert testing

* refactor: added version for mysql docker compose file

* test: test commit

* updated snapshot and fix test (#5032)

* removed mattermost-plugin from make rules

* removed: mattermost-plugin code from the repo

* updated snapshot and fix test

* Updated snapshot and removed unnecessary tests

* chore: minor fix ci

* refactor: removed isplugin code from server

* final attempt

* ci: Minor ci tweaks and upgrades

---------

Co-authored-by: Antonis Stamatiou <[email protected]>
@Rajat-Dabade Rajat-Dabade removed the Do Not Merge Should not be merged until this label is removed label Aug 28, 2024
@Rajat-Dabade Rajat-Dabade merged commit bfaa37f into main Aug 28, 2024
17 checks passed
@Rajat-Dabade Rajat-Dabade deleted the deprecate-isplugin-code branch August 28, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants