Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old network routing module #3655

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Aleksander1234519
Copy link
Collaborator

@Aleksander1234519 Aleksander1234519 commented Jan 6, 2025

#3354 (still WIP)

Allgemeines Vorgehen: COntrib für Contrib durchgehen und alle Tests und Errors lösen, gucken ob die Änderungen die Tests behoben haben. Insgesamt 18 contribs, die nicht duchlaufen.

Tests im core:

ControlerIT.java

  • testTravelTimeCalculation() scheint durch accessegress nun um 0.5s vom vorherigen Zielwert abzuweichen
    -> die Berechnung geht von 1 Sekunde zusätzlicher TT wegen dem Buffer aus, anscheinend gibt es diese Buffer TT aber nicht in dem AccessEgressModul
    -> die TT wird zwar korrekt berechnet, allerdings nicht richtig übernommen, weil die tt von double zu int gecasted wird. Dadurch gehen die Nachkommastellen verloren

ScoreStatsModuleTest

  • the original test, never even Tests the accessEgressModeToLink Type. It just Tests for the None type. When activating the accesEgressRouter, even the original test fails! We probably need to Change the reference values
  • second test can't open file because it is used by other process? (Test also failed in the original Version)
    -> Will probably resolve itself after first test was fixed
    -> config.controller().setDumpDataAtEnd(false);
  • Ein mal die neuen Werte ausrechnen und validieren, indem man in die Events-file guckt

Update:
Many contribs do not work without the old network routing module. "ev" and "roadpricing" for example do not accept access egress routing at all. Since many contribs have a dependency on these modules, we may need to rework these contribs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant