Do not auto-enable the cds remote #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems more likely than not that people don't have datalad-cds installed at the time of cloning a dataset. Thus, auto-enabling leads to some potentially confusing error messages and then leaves the repository in a state in which the remote is disabled. The message when cloning a repository with a not-auto-enabling cds remote is more appropriate, I think.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 89.26% 89.26%
=======================================
Files 5 5
Lines 149 149
=======================================
Hits 133 133
Misses 16 16 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems more likely than not that people don't have datalad-cds installed at the time of cloning a dataset. Thus, auto-enabling leads to some potentially confusing error messages and then leaves the repository in a state in which the remote is disabled. The message when cloning a repository with a not-auto-enabling cds remote is more appropriate, I think.