Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allow-unverified-downloads in initremote #19

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

matrss
Copy link
Owner

@matrss matrss commented Aug 28, 2024

This config setting is meant to protect against downloads from sources that can potentially be spoofed, e.g. private IP addresses which could be assigned to different machines on different networks. We know that this isn't the case for the CDS remote: the target for requests is always determined by the cdsapi package, which in turn talks to the CDS service and does TLS verification due to using HTTPS.

This means that we are unaffected by the security issue the setting is meant to protect against. So there is no need for a user of the CDS special remote to manually set the option in every repository, we might as well do it for them.

This config setting is meant to protect against downloads from sources
that can potentially be spoofed, e.g. private IP addresses which could
be assigned to different machines on different networks. We know that
this isn't the case for the CDS remote: the target for requests is
always determined by the cdsapi package, which in turn talks to the CDS
service and does TLS verification due to using HTTPS.

This means that we are unaffected by the security issue the setting is
meant to protect against. So there is no need for a user of the CDS
special remote to manually set the option in every repository, we might
as well do it for them.
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.26%. Comparing base (8653448) to head (4d3fe0e).
Report is 1 commits behind head on main.

Files Patch % Lines
src/datalad_cds/cds_remote.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   89.79%   89.26%   -0.54%     
==========================================
  Files           5        5              
  Lines         147      149       +2     
==========================================
+ Hits          132      133       +1     
- Misses         15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matrss matrss merged commit a5d1e53 into main Aug 28, 2024
6 of 9 checks passed
@matrss matrss deleted the set-allow-unverified-downloads-in-initremote branch August 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant