Set allow-unverified-downloads in initremote #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config setting is meant to protect against downloads from sources that can potentially be spoofed, e.g. private IP addresses which could be assigned to different machines on different networks. We know that this isn't the case for the CDS remote: the target for requests is always determined by the cdsapi package, which in turn talks to the CDS service and does TLS verification due to using HTTPS.
This means that we are unaffected by the security issue the setting is meant to protect against. So there is no need for a user of the CDS special remote to manually set the option in every repository, we might as well do it for them.