feat(ui,ffi): Add the favourite room list filter
#3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
approved these changes
Feb 19, 2024
crates/matrix-sdk-ui/src/room_list_service/filters/favourite.rs
Outdated
Show resolved
Hide resolved
This patch adds the `favourite` filter, to filter out rooms that are not marked as favourite.
…ters`. This patch adds missing documentation for the `filters` module.
This patch implements the `RoomListEntriesDynamicFilterKind::Favourite` variant.
Hywan
force-pushed
the
feat-ui-room-list-filters-favourite
branch
from
feef04e to
12d5f51
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
==========================================
- Coverage 83.87% 83.86% -0.02%
==========================================
Files 230 231 +1
Lines 23830 23838 +8
==========================================
+ Hits 19987 19991 +4
- Misses 3843 3847 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
favouriteroom list filter.This PR should be be reviewed commit-by-commit, though the patches are rather simple.
RoomNotableTags#3111