Fix concurrency bug breaking Website Selector #22990
Open
+39
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathangavin
added
Bug
sgiehl
reviewed
Jan 29, 2025
mneudert
requested changes
Jan 30, 2025
mneudert
requested changes
Feb 3, 2025
mneudert
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See DEV-18780.
If a user is viewing a report which is available for the current site but is unavailable on another site, switching to the site can trigger the matomoPageChange event, which will abort Ajax calls still in progress, including the call for the SiteSelector. By preventing the SiteSelector ajax call from being added into the GlobalAjaxQueue, it is not impacted by any abort events when a report change. There shouldn't be any side effects with not aborting the SiteSelector ajax call in this situation.
Review