CR feedback.

mathworks · May 28, 2024 · b0fff52 · b0fff52
1 parent 2252bb3
commit b0fff52
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/llfs/basic_log_storage_reader.hpp b/src/llfs/basic_log_storage_reader.hpp
@@ -147,11 +147,8 @@ class BasicLogStorageReader : public LogDevice::Reader
 
   void refresh_view(slot_offset_type upper_bound)
   {
-    this->data_ = [&] {
-      ConstBuffer b = this->context_.buffer_.get(this->offset_);
-
-      return ConstBuffer{b.data(), slot_clamp_distance(this->offset_, upper_bound)};
-    }();
+    const ConstBuffer b = this->context_.buffer_.get(this->offset_);
+    this->data_ = ConstBuffer{b.data(), slot_clamp_distance(this->offset_, upper_bound)};
   }
 
   //==#==========+==+=+=++=+++++++++++-+-+--+----- --- -- -  -  -   -

diff --git a/src/llfs/slot.hpp b/src/llfs/slot.hpp
@@ -124,7 +124,7 @@ inline isize slot_difference(slot_offset_type x, slot_offset_type y)
 inline usize slot_abs_distance(slot_offset_type x, slot_offset_type y)
 {
   if (slot_less_than(y, x)) {
-    return slot_abs_distance(y, x);
+    return x - y;
   }
   return y - x;
 }