Fix/realtime kwargs #258
Merged
Fix/realtime kwargs #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped the library version to 3.8.3 in multiple file. Updated the changelog to document this fix.
MagicTheDev
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to update the version of the package and fix bugs related to war-related endpoints. The most important changes include updating the version number, fixing a bug where the
realtimeparameter was passed twice, and updating the documentation to reflect the new version.Version update:
coc/__init__.py: Updated the version from3.8.2to3.8.3.docs/conf.py: Updated the release version from3.8.2to3.8.3.pyproject.toml: Updated the version from3.8.2to3.8.3.Bug fixes:
coc/client.py: Fixed a bug in several war-related endpoints where therealtimeparameter was passed twice to the HTTP client by usingself._defaultsin the method calls. [1] [2] [3]docs/miscellaneous/changelog.rst: Added an entry for version3.8.3detailing the bug fix for therealtimeparameter issue.