Preserve placeholder text on focus

[mlms13]

This series of commits gives the plugin the option to behave more like the placeholder implementation in Chrome and Firefox. Placeholder text remains visible until characters are entered into the input. See #92 for more info.

[amerikan]

@mlms13 seems like a good thing to have. The code has fallen behind. Also, we don't need an option, it should be the default setting. All modern browsers (except ie 10/11) behave this way (they preserve the placeholder on focus). Can you please update? Thanks.

[amerikan]

@mlms13 ping

[mlms13]

Hey, I'm about to jump on a plane. I'll see if I have a chance to make your suggested changes then. I'm excited the library is being maintaned again. :)

[mlms13]

It should be up-to-date now, but I haven't tested it since merging master into this branch. I'll run it in some browsers on Monday to make sure it still behaves as expected.

[ghost]

@mlms13 Were you able to solve this?

[mlms13]

Just fixed a typo that was causing the grunt build to fail. I tested in IE8 and IE9, and as far as I can tell, everything looks ok to me.

[amerikan]

@mlms13 I haven't had time to test it yet, but I do see you use .on method to attach an event handler, however according to the jquery docs, .on() was introduced in jQuery 1.7, the jquery-placeholder plugin itself at this point must be compatible with jQuery 1.6 so I don't think it'll work. I'm already thinking for jquery-placeholder 2.0 to drop 1.6 support, but for now it needs to support it.

[gabskoro]

Tested on IE11 and nothing, it still disappeares

[mlms13]

@gabskoro I don't think the jquery-placeholder plugin polyfills IE11, because it natively supports the placeholder attribute. And, unfortunately, its native implementation makes the text disappear on focus. 😞

[mlms13]

Looks like my branch is conflicting again. I'm happy to keep it up to date if there's a chance that this will be merged.

[amerikan]

@mlms13 yes please update.

@gabskoro see issue #204, ideally we would want to allow a developer to override native if desired, though still have to figure out how to do that

[Alex1990]

If a user pastes some text by the Paste command in context menu, the keydown or keyup events cannot be triggered.

This feature needs an event like input event in IE10+ and other modern browers. See this article A near-perfect oninput shim for IE 8 and 9. Of course, you can write a simplified version.

[mlms13]

@Alex1990 ... ignore my original comment... I got it now. Yes, since we're no longer targeting focus, we need more intelligent ways to figure out if the input contains text.

@amerikan If there's anything else I need to do, feel free to add it to this checklist.

• Fix merge conflicts
• Be smarter about checking for input and clearing the placeholder
• Test in some virtual machines

I'm not including the request to override IE 10's behavior, because that seems like a bigger issue that changes the behavior of this plugin (ie feature detection will no longer be enough)... a bit outside of the scope of this PR.

[mlms13]

If anyone is still interested in this feature, my fork is up to date with the latest changes. It hasn't been tested recently, and it looks like a weird merge happened with the setPlaceholder method. Since I no longer need to support old IE, and there doesn't seem to be interest in merging this upstream, I probably won't continue to keep it up to date, but if anyone else wants to maintain it, it's all yours. :)

[amerikan]

@mlms13 I believe this PR got automatically closed because the master branch was deleted in favor of the gh-pages branch which serves as the project demo. So if you would like to make this changes to the gh-pages branch I can test then merge. I really think it's a good feature and mimics the behavior of the modern browsers excluding IE of course.

[mlms13]

Ah, makes sense. I'll try to fix up the weirdness I'm seeing in the setPlaceholder method, and I'll do some testing and reopen against gh-pages.