Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot of changes #21

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Lot of changes #21

wants to merge 10 commits into from

Conversation

iamtraction
Copy link

Addition

  • Added support for Amharic language

Improvements

  • If URL (query text) is over 2083 chars, send using POST

Fixes

  • Fixed Sundanese language
  • Fixed BAD_NETWORK error on every request
  • Fixed null responses

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.3%) to 88.571% when pulling 8a288f5 on snkrsnkampa:master into 52d2f74 on matheuss:master.

@JukeboxRhino
Copy link
Collaborator

@snkrsnkampa Try adding 'use strict'; and updating test coverage. https://travis-ci.org/matheuss/google-translate-api/builds/234231062

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "google-translate-api",
"version": "2.2.2",
"version": "2.3.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this 👌

@coveralls
Copy link

coveralls commented Jun 28, 2017

Coverage Status

Coverage decreased (-2.3%) to 88.571% when pulling 88d243f on snkrsnkampa:master into 3f17903 on matheuss:master.

@iamtraction iamtraction changed the title v2.3.0 - fixed linter issues Lot of changes Jul 1, 2017
@neran27
Copy link

neran27 commented Apr 7, 2018

Hi @k3rn31p4nic , myself not able to get the output for the hindi language, can you please help me how to add support for hindi language.

@iamtraction
Copy link
Author

@neran27 It already supports Hindi. Are you sure you're doing it right?

Btw, your question is related to this PR, so you should open a new issue for that.
Or you can also try my library (k3rn31p4nic/google-translate-api) if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants