Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "Suggestions" use Entities (IOS-190) #1155

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Make "Suggestions" use Entities (IOS-190) #1155

merged 6 commits into from
Nov 16, 2023

Conversation

zeitschlag
Copy link
Contributor

@zeitschlag zeitschlag commented Nov 13, 2023 •
edited
Loading

  • Replace Core Data on "Suggested Accounts"-screen which appears when you don't follow any people (For testing, you might need to create a new account)
  • I also added some quality of life-improvements (like showing the spinner on every UIViewController and not just rootViewController)

@zeitschlag zeitschlag force-pushed the ios-190-user-suggestions branch from b82e4e5 to 1416e06 Compare November 13, 2023 14:12
@zeitschlag zeitschlag marked this pull request as ready for review November 13, 2023 14:53
@zeitschlag zeitschlag requested a review from kimar November 13, 2023 14:53
kimar
kimar approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@kimar kimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just a few remarks and ❓

MastodonSDK/Sources/MastodonSDK/Entity/Mastodon+Entity+Account.swift Show resolved Hide resolved
MastodonSDK/Sources/MastodonSDK/Entity/Mastodon+Entity+Account.swift Show resolved Hide resolved
MastodonSDK/Sources/MastodonSDK/Entity/Mastodon+Entity+Account.swift Outdated Show resolved Hide resolved
@zeitschlag zeitschlag force-pushed the ios-190-user-suggestions branch from 7de8524 to b8837cd Compare November 15, 2023 11:03
@zeitschlag zeitschlag force-pushed the ios-190-user-suggestions branch from b8837cd to b6f3aa5 Compare November 16, 2023 08:33
@zeitschlag zeitschlag force-pushed the ios-190-user-suggestions branch 2 times, most recently from d5f05e1 to 4014a1b Compare November 16, 2023 09:20
@zeitschlag zeitschlag force-pushed the ios-190-user-suggestions branch from 4014a1b to a2aa9b7 Compare November 16, 2023 09:29
@zeitschlag zeitschlag merged commit 6e149cd into develop Nov 16, 2023
1 check passed
@zeitschlag zeitschlag deleted the ios-190-user-suggestions branch November 16, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimar kimar kimar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeitschlag @kimar