IOS-174: Don't persist followers #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
changed the title
zeitschlag
force-pushed
the
remove_coredata/followers
branch
from
d9d9a3c to
ed98024
Compare
zeitschlag
force-pushed
the
remove_coredata/followers
branch
from
86ecbde to
608d2a5
Compare
zeitschlag
force-pushed
the
remove_coredata/followers
branch
from
dffd84d to
611d92d
Compare
zeitschlag
force-pushed
the
remove_coredata/followers
branch
from
611d92d to
83e4584
Compare
kimar
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
LGTM 👍 I was just wondering if we could even get rid of MastodonAuthenticationBox.sharedCache finally, as the reason for implementing this has been the incorrect relationships we're keeping in the Database. But I've looked at the code and now I'm uncertain wether the better point in time wouldn't be once MastodonUser has been cleared from CoreData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: Don't use
MastodonUseron "Followers"-screen, butMastodon.Entity.AccountThis PR build on Don't persist following #1136, but should be merged in, this was done automatically 🤯develop, once Don't persist following #1136 is merged