-
-
Notifications
You must be signed in to change notification settings - Fork 276
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Replaces the view previously in the Navigation Bar with the new, so-called Timeline Status Pill - We use it to show three states: When a post has been published (successfully), when new statuses are available or when five (I slightly increased the limit) requests failed - The Timeline Status Pill features some fancy animations and a little shadow - For further details have a look at IOS-234 🙂 ![ios_234_iphone](https://github.com/mastodon/mastodon-ios/assets/2580019/c77df339-aa72-406f-8be3-572acb244246) ![ios_234_ipad](https://github.com/mastodon/mastodon-ios/assets/2580019/f2fafc4c-ed5a-4afb-86a7-5de69325997b) To simulate the different reasons I used this snippet. When you press the Settings-button, you should see the 💊 : ```diff diff --git a/Mastodon/Scene/HomeTimeline/HomeTimelineViewController.swift b/Mastodon/Scene/HomeTimeline/HomeTimelineViewController.swift index 8559025d4..0eb27d0e8 100644 --- a/Mastodon/Scene/HomeTimeline/HomeTimelineViewController.swift +++ b/Mastodon/Scene/HomeTimeline/HomeTimelineViewController.swift @@ -488,9 +488,14 @@ extension HomeTimelineViewController { } @objc private func settingBarButtonItemPressed(_ sender: UIBarButtonItem) { - guard let setting = context.settingService.currentSetting.value else { return } + // don't commit + timelinePill.update(with: .newPosts) + showTimelinePill() - _ = coordinator.present(scene: .settings(setting: setting), from: self, transition: .none) +// guard let setting = context.settingService.currentSetting.value else { return } +// +// _ = coordinator.present(scene: .settings(setting: setting), from: self, transition: .none) + // don't commit } @objc private func refreshControlValueChanged(_ sender: RefreshControl) { ```
- Loading branch information
Showing
12 changed files
with
274 additions
and
551 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.