Skip to content

Commit

Permalink
Merge pull request #13 from airbytehq/master
Browse files Browse the repository at this point in the history
pulling in changes from master
  • Loading branch information
jhsb25 authored Apr 30, 2024
2 parents 9d16ec3 + e0f9c29 commit 5f680b9
Show file tree
Hide file tree
Showing 1,059 changed files with 37,282 additions and 13,201 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 0.57.3
current_version = 0.58.0
commit = False
tag = False
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(\-[a-z]+)?
Expand Down
70 changes: 70 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
{
"name": "Java Development DevContainer (Generic)",
"image": "mcr.microsoft.com/devcontainers/java:0-17",
"features": {
"ghcr.io/devcontainers/features/docker-in-docker": {},
"ghcr.io/devcontainers/features/java:1": {
"installGradle": true,
"version": "latest",
"jdkDistro": "open",
"gradleVersion": "7.5.1"
},
// Python needed for `airbyte-ci` CLI
"ghcr.io/devcontainers/features/python:1": {
"installGradle": true,
"version": "3.10",
"installTools": true
},
"ghcr.io/devcontainers-contrib/features/poetry:2": {}
},
// Deterministic order reduces cache busting
"overrideFeatureInstallOrder": [
"ghcr.io/devcontainers/features/docker-in-docker",
"ghcr.io/devcontainers/features/java",
"ghcr.io/devcontainers/features/python",
"ghcr.io/devcontainers-contrib/features/poetry"
],
// Configure tool-specific properties.
"customizations": {
"vscode": {
"extensions": [
// Python extensions:
"charliermarsh.ruff",
"matangover.mypy",
"ms-python.python",
"ms-python.vscode-pylance",
// Toml support
"tamasfe.even-better-toml",
// Yaml and JSON Schema support:
"redhat.vscode-yaml",
// Contributing:
"GitHub.vscode-pull-request-github",
// General AI Auto-Complete (Python and Java)
"VisualStudioExptTeam.vscodeintellicode",
// Gradle and Java
"redhat.java",
"vscjava.vscode-gradle",
"vscjava.vscode-java-debug",
"vscjava.vscode-java-test",
"vscjava.vscode-java-dependency"
],
"settings": {
"extensions.ignoreRecommendations": true,
"git.openRepositoryInParentFolders": "always"
}
}
},
// Mark the root directory as 'safe' for git.
"initializeCommand": "git config --add safe.directory /workspaces/airbyte",
// Install Gradle, `airbyte-ci` CLI, and Dagger (installed via airbyte-ci --help)
"postCreateCommand": "make tools.airbyte-ci-dev.install",
"containerEnv": {
// Deterministic Poetry virtual env location: `./.venv`
"POETRY_VIRTUALENVS_IN_PROJECT": "true"
}
// Override to change the directory that the IDE opens by default:
// "workspaceFolder": "/workspaces/airbyte"
// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
4 changes: 2 additions & 2 deletions .devcontainer/java-connectors-generic/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
// Mark the root directory as 'safe' for git.
"initializeCommand": "git config --add safe.directory /workspaces/airbyte",

// Install Gradle, `airbyte-ci` CLI, and Dagger (installed via airbyte-ci --help)
"postCreateCommand": "./gradlew --version && pipx install --editable ./airbyte-ci/connectors/pipelines/ || airbyte-ci --help || true",
// Install `airbyte-ci` and Gradle
"postCreateCommand": "make tools.airbyte-ci-dev.install && ./gradlew --version",

"containerEnv": {
// Deterministic Poetry virtual env location: `./.venv`
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/2-issue-docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ body:
- type: textarea
id: description
attributes:
label: Revelant information
label: Relevant information
description: Please give any additional information you have and steps to reproduce the problem.
- type: textarea
id: logs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ body:
- type: textarea
id: description
attributes:
label: Revelant information
label: Relevant information
description: Please give any additional information you have and steps to reproduce the problem.
- type: textarea
id: logs
Expand Down
88 changes: 88 additions & 0 deletions .github/ISSUE_TEMPLATE/4-issue-abctl.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
name: 🐛 [abctl] Report an issue with the abctl tool
description: Use this template when you experience an issue with the abctl tool
labels: [type/bug, area/abctl, needs-triage]
body:
- type: markdown
attributes:
value: >
<p align="center">
<a target="_blank" href="https://airbyte.com">
<image>
<source srcset="https://raw.githubusercontent.com/airbytehq/airbyte/master/.github/octavia-issue-template.svg">
<img alt="octavia-welcome" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/.github/octavia-issue-template.svg" width="auto" height="120">
</image>
</a>
</p>
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report...
Make sure to update this issue with a concise title and provide all information you have to
help us debug the problem together. Issues not following the template will be closed.
- type: textarea
id: problem
attributes:
label: What happened?
description: Please give any additional information you have and steps to reproduce the problem.
validations:
required: true
- type: textarea
id: expected
attributes:
label: What did you expect to happen?
validations:
required: true
- type: textarea
id: abctlVersion
attributes:
label: Abctl Version
value: |
<details>
```console
$ abctl version
# paste output here
```
</details>
validations:
required: true
- type: textarea
id: dockerVersion
attributes:
label: Docker Version
value: |
<details>
```console
$ docker version
# paste output here
```
</details>
validations:
required: true
- type: textarea
id: osVersion
attributes:
label: OS Version
value: |
<details>
```console
# On Linux:
$ cat /etc/os-release
# paste output here
# On Mac:
$ uname -a
# paste output here
# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```
</details>
validations:
required: true
104 changes: 0 additions & 104 deletions .github/actions/airbyte-ci-requirements/action.yml

This file was deleted.

16 changes: 13 additions & 3 deletions .github/actions/install-airbyte-ci/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,41 @@ inputs:
description: "Path to airbyte-ci source"
required: false
default: airbyte-ci/connectors/pipelines
is_fork:
description: "Whether the PR is from a fork"
required: false
default: "false"
runs:
using: "composite"
steps:
- name: Get changed files
uses: tj-actions/changed-files@v39
uses: tj-actions/changed-files@v44
# When the PR is from a fork, we always install from binary, so we don't need to check for changes
if: inputs.is_fork == 'false'
id: changes
with:
files_yaml: |
pipelines:
- '${{ inputs.path_to_airbyte_ci_source }}/**'
- name: Determine how Airbyte CI should be installed
- name: "Determine how Airbyte CI should be installed"
shell: bash
id: determine-install-mode
# When the PR is from a fork, we always install from binary
if: inputs.is_fork == 'false'
run: |
if [[ "${{ github.ref }}" != "refs/heads/master" ]] && [[ "${{ steps.changes.outputs.pipelines_any_changed }}" == "true" ]]; then
echo "Making changes to Airbyte CI on a non-master branch. Airbyte-CI will be installed from source."
echo "install-mode=source" >> $GITHUB_OUTPUT
echo "SENTRY_ENVIRONMENT=dev" >> $GITHUB_ENV
else
echo "install-mode=binary" >> $GITHUB_OUTPUT
echo "SENTRY_ENVIRONMENT=production" >> $GITHUB_ENV
fi
- name: Install Airbyte CI from binary
id: install-airbyte-ci-binary
if: steps.determine-install-mode.outputs.install-mode == 'binary'
if: steps.determine-install-mode.outputs.install-mode == 'binary' || ${{ inputs.is_fork }} == 'true'
shell: bash
run: |
curl -sSL ${{ inputs.airbyte_ci_binary_url }} --output airbyte-ci-bin
Expand Down
Loading

0 comments on commit 5f680b9

Please sign in to comment.