Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc new #582

Merged
merged 21 commits into from
Apr 4, 2024
Merged

Doc new #582

merged 21 commits into from
Apr 4, 2024

Conversation

fgrunewald
Copy link
Member

Update file format documentation.

pckroon
pckroon requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)
Some obligatory nitpicks

doc/source/file_formats.rst Show resolved Hide resolved
doc/source/file_formats.rst Outdated Show resolved Hide resolved
doc/source/file_formats.rst Show resolved Hide resolved
doc/source/file_formats.rst Outdated Show resolved Hide resolved
doc/source/file_formats.rst Show resolved Hide resolved
doc/source/file_formats.rst Outdated Show resolved Hide resolved
doc/source/file_formats.rst Outdated Show resolved Hide resolved
doc/source/file_formats.rst Outdated Show resolved Hide resolved
doc/source/file_formats.rst Outdated Show resolved Hide resolved
doc/source/file_formats.rst Show resolved Hide resolved
@fgrunewald fgrunewald requested a review from pckroon April 3, 2024 16:16
pckroon
pckroon requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, apart from the unresolved comments/conversations. We could either decide to close these, or indeed change the docs a little bit more. I'll see if I can get readthedocs to build and show these.

@pckroon
Copy link
Member

pckroon commented Apr 4, 2024

https://vermouth-martinize.readthedocs.io/en/doc-new/

@fgrunewald
Copy link
Member Author

@pckroon I updated the sections. I think we're good to go

pckroon
pckroon approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@pckroon pckroon merged commit ad27bdf into master Apr 4, 2024
8 checks passed
@pckroon pckroon deleted the doc-new branch April 4, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pckroon pckroon pckroon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgrunewald @pckroon @Tsjerk