-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-el fix #559
Merged
Merged
-el fix #559
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d0feb7f
ensured el flag is used
csbrasnett 8ef0e42
fixed el threshold application
csbrasnett edbfb6f
removed brackets
csbrasnett bcf4699
didn't account for constant forces
csbrasnett 99c0452
added tests for rubber band application
csbrasnett 9104cec
added decay tests
csbrasnett 1617e84
corrected behaviour
csbrasnett a14cd23
expanded docstring of compute_force_constants
csbrasnett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to test floats you can use
np.allclose(array1, array2)
together with setting the absolute tolerance for the float. Or Peter seems to prefer the pytest build in using pytest.approx.