First draft of a ProcessorPipeline #552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pckroon
added
hacktoberfest-accepted
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a first stab at making a ProcessorPipeline. I've set it up so that it is a proper recursive DiGraph, but with a convenient
.addmethod. I've also mashed it into bin/martinize2, probably breaking quite a bit of functionality in the process.There is a lot of logic in bin/martinize2. Some of it is unpacking CLI args (which is fine-ish), some of it is error checking (also fine), but part is also things like writing debug output pdb files. Things like the latter should be squeezed into processors.
Please have a look at it to see if you like the direction. I need to brood on it for a little bit before continuing.