Unflake hypothesis tests #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pckroon
requested review from
fgrunewald and
jbarnoud
and removed request for
fgrunewald
jbarnoud
previously approved these changes
Feb 3, 2021
vermouth/tests/test_molecule.py
Outdated
| @hypothesis.given( | ||
| moltype=st.one_of( | ||
| st.none(), | ||
| st.text(st.characters(blacklist_categories=('C', 'Z')), min_size=1) |
There was a problem hiding this comment.
Maybe an example case with a character from class C and Z just to know how things explode or not? I would not fight for it, though. If you are using a bell character as an atom name you are looking for problems and you deserve them.
There was a problem hiding this comment.
I had false test failures (because of how I test molecule.__str__) where an interaction type is named "0 a" with 0 interactions, which is in "0 atoms", resulting in test failure. It doesn't blow up perse.
Or a molecule name matching an empty interaction type, something along those lines.
Easier to sanitize the input a bit than figure out and asssume out all possible false failure modes.
Restrict hypothesis strategies generating interaction types and molecule names from using characters in the unicode classes Z (separators) and C (control characters).
jbarnoud
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict hypothesis strategies generating interaction types and molecule names from using characters in the unicode classes Z (separators) and C (control characters).
This should resolve some intermittent test failures, for example the one in #328