Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an implied default compartment when compartment definitions are omitted #27

Closed
wants to merge 2 commits into from

Conversation

ma3ke
Copy link
Collaborator

@ma3ke ma3ke commented May 30, 2024

These two configurations now produce the same behavior.

 {
        "space": {
                "size": [100, 100, 100],
-               "compartments": [
-                       {
-                               "id": "main",
-                               "shape": "spherical"
-                       }
-               ],
                "resolution": 0.5
        },
        "output": {
                "title": "3lyz",
                "dir": "outputs"
        },
        "segments": [
                {
                        "name": "3lyz",
                        "number": 100000,
-                       "compartments": ["main"],
                        "path": "structures/3lyz.pdb"
                }
        ]
 }

In case a "compartments" field is set for any of the segments, an error is thrown describing that the implied "compartments" definition in the "space" section is valid only if no segment has a "compartments" field.

@ma3ke ma3ke linked an issue May 30, 2024 that may be closed by this pull request
@ma3ke ma3ke force-pushed the 26-compartment-defaults branch from 2f79e95 to 4673fca Compare May 30, 2024 09:51
@ma3ke
Copy link
Collaborator Author

ma3ke commented Sep 20, 2024

Though we may come back to this notion later (yet I doubt it), I'm closing this now.

@ma3ke ma3ke closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour when no compartments are defined
1 participant