Pack according to domains #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a quick in-progress pull request. Still working on it. See issue #1 for some info on what is left to do and left to verify before we merge this. |
The storage of the background has a four-fold reduced memory footprint with this change, at the cost of converting to float32-arrays between functions.
|
This was a cute attempt at an earlier state of affairs for bentopy. It served as a valuable experiment! Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1
Requires some extensive testing, because we still want to see a nice and well-stirred result. Particularly for cases where the number of segments to be placed is smaller, we need to make sure that things are still uniformly distributed.