Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove padding scheme and rely on valid mode for convolution #18

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

ma3ke
Copy link
Collaborator

@ma3ke ma3ke commented Mar 27, 2024

This change reverts the padding scheme I had introduced earlier to circumvent an issue that I now know can be solved much more simply and elegantly.

Closes #16

@ma3ke ma3ke linked an issue Mar 27, 2024 that may be closed by this pull request
This change reverts the padding scheme I had introduced earlier to
circumvent an issue that I now know can be solved much more simply and
elegantly.

Closes #16
@ma3ke
Copy link
Collaborator Author

ma3ke commented Mar 27, 2024

That was surprisingly easy. Seems to check out well in my local test-cases. These include spherical systems (analytical and from prepared voxel masks of spheres) and cuboids.

Some changes between the produced placement lists are to be expected, since the random number generator can be hit in a different order due to removing the previous padding scheme. In case there is a difference in the produced placement lists, an inspection of the rendered structure is warranted. Nevertheless, I do not foresee much trouble.

@ma3ke
Copy link
Collaborator Author

ma3ke commented Mar 27, 2024

Also interesting: there appears to be a runtime improvement associated with this change. Initially, I had also added the sliced padding system in order to bring about some memory-footprint improvements as well as a hopeful runtime improvement. The former was negligible, as was the latter. Rolling back that earlier change shows that with the current state of the project, it had actually become a slight performance disadvantage.

@ma3ke ma3ke merged commit 60571d4 into main Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove early padding mechanism
1 participant