Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minecraft on Marp theme to list of community themes #5

Closed
wants to merge 2 commits into from

Conversation

mikael-ros
Copy link
Contributor

This is my own theme. I saw someone else adding their own, so I figured I would too.

Why awesome?

  • It has a small amount of recognition already, with 2 stars
  • It is a good example of what you can do with the sheer flexibility Marp provides

@mikael-ros mikael-ros changed the title Added Minecraft on Marp theme Add Minecraft on Marp theme Oct 29, 2024
@mikael-ros mikael-ros changed the title Add Minecraft on Marp theme Add Minecraft on Marp theme to list of community themes Oct 29, 2024
@yhatt
Copy link
Member

yhatt commented Oct 29, 2024

@mikael-ros
Copy link
Contributor Author

I was missing a period, fixed now. Sorry for not checking the linter, I made these requests before bed. Next time I contribute in any Marp project (or elsewhere for that matter) I'll make a point of checking the rules and contributing guidelines. I do genuinely apologize for being a bit of a newbie when it comes to this.

@yhatt
Copy link
Member

yhatt commented Jan 3, 2025

This pull request cannot be merged due to the following reasons:

  • A merge conflict was introduced after merging Add Neobeam to list of community themes #4. Your explicit action is required to resolve this conflict.
  • The theme and its README are containing direct references to commercial resources or descriptions that may encourage such references. Marp team must avoid any legal risks.

@yhatt yhatt closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants