prepend http_prefix to links, if defined #9
Conversation
|
Is this so it handles both HTTP and HTTPS links properly? |
|
Also, please don't change the version number. I'll do that when I release the gem. |
| @@ -21,7 +21,9 @@ def initialize(app, options_hash = {}, &block) | |||
| def breadcrumbs(page, separator: @separator, wrapper: @wrapper) | |||
| hierarchy = [page] | |||
| hierarchy.unshift hierarchy.first.parent while hierarchy.first.parent | |||
| hierarchy.collect {|page| wrap link_to(page.data.title, "/#{page.path}"), wrapper: wrapper }.join(h separator) | |||
| hierarchy.collect {|page| | |||
| wrap link_to(page.data.title, "#{File.join((app.config[:http_prefix] || "/"), page.path)}"), | |||
There was a problem hiding this comment.
This would be better with URI.join.
|
This should not be necessary at all. The URLs that this gem generates aren't full prefixed URLs; they're paths. So the browser should automatically use the same HTTP prefix as the current page. Do you have a use case where that doesn't work? |
|
I don't seem to be able to use the gem when deploying to a suburi (e.g., http://www.example.com/home). In my opinion it is because the gem generates absolute URLs, that is, it prepends a "/" to all URLs. The generated URLs, therefore, end up pointing to the wrong location if a site lives on a subdirectory. The way I understand middleman, this is one of the reasons Anyhow, live example of the problem I run into lives at http://gasapp.me/help-staging/admin/getting-started.html. If there is a way to solve the issue without changing the code, even better. |
|
I see. I will take a look at this in detail later. Note that I will need tests before I merge this pull request. |
| @@ -1,3 +1,3 @@ | |||
| module BreadcrumbsVersion | |||
| VERSION = '0.4.1' | |||
| VERSION = '0.4.2' | |||
There was a problem hiding this comment.
Don't change the version number. I'll do that when I make a release.
|
Hi - |
|
Thank you. This still needs tests, however. |
I have slightly changed your code to prepend the value of
:http_prefixto the generated links. If:http_prefixis not defined the gem behaves as before.This allows to use your gem on sites deployed on a suburi.