rework tests #157
Merged
rework tests #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marler8997
force-pushed
the
tests
branch
16 times, most recently
from
3e83fbe to
19153ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the zigup tests were a single program that ran from start to finish. There was no isolation between tests and no way to start anywhere other than the beginning. This change turns all the tests into steps in Zig's build system. This allows us to leverage things like the cache to prevent re-running the same steps, zig's build parallelism and the build's error-reporting mechanisms.
The general technique I've used here is that every test has its own output directory in the cache to store its results (i.e. any zig compilers that were fetched). In addition, every test can also be given an "input environment", which would be an output directory from a previously executed test. This allows you to branch multiple tests from the same state/filesystem and prevents re-executing the same steps.