Merge pull request #235 from MaximeRivest/main

fix joins because of changes in polars api
markfairbanks · Feb 7, 2024 · f660db8 · f660db8
2 parents 8f9b1ba + b35fa96
commit f660db8
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tidypolars/tibble.py b/tidypolars/tibble.py
@@ -345,7 +345,7 @@ def inner_join(self, df, left_on = None, right_on = None, on = None, suffix = '_
         """
         if (left_on == None) & (right_on == None) & (on == None):
             on = list(set(self.names) & set(df.names))
-        return super().join(df, left_on, right_on, on, 'inner', suffix).pipe(from_polars)
+        return super().join(df, on, 'inner', left_on = left_on, right_on= right_on, suffix= suffix).pipe(from_polars)
 
     def left_join(self, df, left_on = None, right_on = None, on = None, suffix = '_right'):
         """
@@ -372,7 +372,7 @@ def left_join(self, df, left_on = None, right_on = None, on = None, suffix = '_r
         """
         if (left_on == None) & (right_on == None) & (on == None):
             on = list(set(self.names) & set(df.names))
-        return super().join(df, left_on, right_on, on, 'left', suffix).pipe(from_polars)
+        return super().join(df, on, 'left',  left_on = left_on, right_on= right_on, suffix= suffix).pipe(from_polars)
 
     def mutate(self, *args,
                by = None,
@@ -465,7 +465,7 @@ def full_join(self, df, left_on = None, right_on = None, on = None, suffix: str
         """
         if (left_on == None) & (right_on == None) & (on == None):
             on = list(set(self.names) & set(df.names))
-        return super().join(df, left_on, right_on, on, 'outer', suffix).pipe(from_polars)
+        return super().join(df, on, 'outer',  left_on = left_on, right_on= right_on, suffix= suffix).pipe(from_polars)
 
     def pivot_longer(self,
                      cols = everything(),
@@ -940,15 +940,15 @@ def write_csv(self,
                   has_headers = True,
                   sep = ','):
         """Write a data frame to a csv"""
-        return super().to_csv(file, has_headers, sep)
+        return super().write_csv(file, include_header = has_headers, separator = sep)
 
     def write_parquet(self,
                       file = str,
                       compression = 'snappy',
                       use_pyarrow = False,
                       **kwargs):
         """Write a data frame to a parquet"""
-        return super().to_parquet(file, compression, use_pyarrow, **kwargs)
+        return super().write_parquet(file, compression = compression, use_pyarrow = use_pyarrow, **kwargs)
 
 def desc(x):
     """Mark a column to order in descending"""