fix: refactor types for rsaFunctionFor to include BufferLike #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR updates the returned function parameter types for
rsaFunctionFor()
to include BufferLike. The original code already performs checks and assumes that EncodingOptions can be a BinaryLike, but this type wasn’t properly reflected in the definitions.This omission causes issues during TypeScript compilation (tsc) in cases where passing a private key works as intended but fails the type check. For example:
Also noting, this change does the type checking logic inline. Normally, I’d pull these into utility functions to keep the function body cleaner and more focused. However, I’m unsure where this type of utility would belong in the project structure. Additionally, given that this functionality might be deprecated, I’m not certain if it’s worth the effort to refactor at this point.
That said, I’m happy to make changes based on the team’s preferences.
What