Refactor & Fix Tests #224
Merged
Refactor & Fix Tests #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
boorad
commented
Jan 29, 2024
boorad
commented
- fix lint issues from More subtle implementations #211
- fix github actions warnings
- rework test suite for more visibility into success/failure in example app
- fix failing/crashing tests
This was referenced Jan 29, 2024
Closed
This was referenced Jan 31, 2024
Closed
Szymon20000
reviewed
Feb 7, 2024
Szymon20000
reviewed
Feb 7, 2024
|
I run the app locally and compare the tests with what was passing before last 2 merged pr and it seems to be on par. I will go strait and marge it. |
|
Thank you very much @boorad ! |
|
This is amazing, thanks @boorad ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.